Shashwat Vangani

@TheBlueMatt Hi, after rebasing, I tried using the new syntax to handle the legacy fields. Here's the diff I wrote: ```diff (5, AwaitingInvoice) => { (0, expiration, required), (2, retry_strategy,...

> legacy writes are supposed to be Options. Yep! I believe that's working perfectly. The issue was `route_params_config.max_total_routing_fee_msat` is already `Option`, but I was trying to return `Some(route_params_config.max_total_routing_fee_msat)` which caused...

Updated from [pr3342.07](https://github.com/shaavan/rust-lightning/commits/pr3342.07) to [pr3342.08](https://github.com/shaavan/rust-lightning/commits/pr3342.08) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3342.07..pr3342.08)): Addressed @jkczyz suggestion Changes: 1. Introduce the legacy macro to support the `_max_total_routing_fee_msat`.

Updated from [pr3342.08](https://github.com/shaavan/rust-lightning/commits/pr3342.08) to [pr3342.09](https://github.com/shaavan/rust-lightning/commits/pr3342.09) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3342.08..pr3342.09)): Addressed @jkczyz comment Changes: 1. Updated `_encode_tlv` macro to introduce compile time type check.

Updated from [pr3342.09](https://github.com/shaavan/rust-lightning/commits/pr3342.09) to [pr3342.10](https://github.com/shaavan/rust-lightning/commits/pr3342.10) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3342.09..pr3342.10)): Addressed @jkczyz, @TheBlueMatt comments Changes: 1. Update call-site so that user can call `RouteParameters::default()` instead of `None`, in default case. 2. Reorder tlv ordering...

Updated from [pr3342.10](https://github.com/shaavan/rust-lightning/commits/pr3342.10) to [pr3342.11](https://github.com/shaavan/rust-lightning/commits/pr3342.11) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3342.10..pr3342.11)): Changes: 1. Rebase on main.

Updated from [pr3342.11](https://github.com/shaavan/rust-lightning/commits/pr3342.11) to [pr3342.12](https://github.com/shaavan/rust-lightning/commits/pr3342.12) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3342.11..pr3342.12)): Addressed @jkczyz comments. Changes: 1. Implement default for `RouteParametersConfig`. 2. Remove extra whitespace.

Updated from [pr3342.12](https://github.com/shaavan/rust-lightning/commits/pr3342.12) to [pr3342.13](https://github.com/shaavan/rust-lightning/commits/pr3342.13) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3342.12..pr3342.13)): Addressed @TheBlueMatt comments: Changes: 1. Update the documentation and naming for `with_user_config` to be clearer and explicitly state that we ignore the `max_total_routing_fee_msat` application...

Updated from [pr3163.01](https://github.com/shaavan/rust-lightning/commits/pr3163.01) to [pr3163.02](https://github.com/shaavan/rust-lightning/commits/pr3163.02) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3163.01..pr3163.02)): Addressed @jkczyz and @TheBlueMatt comments Changes: 1. Rebase on main. 2. Introduce a _fixup_ commit to introduce `context` in `respond_with_reply_path`.

Updated from [pr3163.02](https://github.com/shaavan/rust-lightning/commits/pr3163.02) to [pr3163.03](https://github.com/shaavan/rust-lightning/commits/pr3163.03) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3163.02..pr3163.03)): Addressed @TheBlueMatt and @jkczyz comments Changes: 1. Squashed the commits 2. Update the Commit description to be clearly detailed. Thanks, @TheBlueMatt for the suggestion,...