Shashwat Vangani
Shashwat Vangani
Updated from [pr2996.10](https://github.com/shaavan/rust-lightning/commits/pr2996.10) to [pr2996.11](https://github.com/shaavan/rust-lightning/commits/pr2996.11) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.10..pr2996.11)): Addressed @TheBlueMatt comment Changes: 1. Reverted `handle_custom_message` to default to avoid API changes. 2. Introduced a new `test_handle_custom_message` handler for the `ResponseInstruction` tests.
Updated from [pr2996.11](https://github.com/shaavan/rust-lightning/commits/pr2996.11) to [pr2996.12](https://github.com/shaavan/rust-lightning/commits/pr2996.12) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.11..pr2996.12)): Addressed @jkczyz comment. 1. Removed the test-specific handle_custom_message, and instead utilized the newly introduced `TestCustomMessage` variants to facilitate the `respond_with_reply_path` test. 2. Expanded the...
Updated from [pr2996.12](https://github.com/shaavan/rust-lightning/commits/pr2996.12) to [pr2996.13](https://github.com/shaavan/rust-lightning/commits/pr2996.13) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.12..pr2996.13)): Addressed @jkczyz comment Changes: 1. Removed redundant diff to keep commits atomic. 2. Improved the `SendError::PathNotFound` docs. 3. Removed the redundant granular comments from...
Updated from [pr2996.13](https://github.com/shaavan/rust-lightning/commits/pr2996.13) to [pr2996.14](https://github.com/shaavan/rust-lightning/commits/pr2996.14) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.13..pr2996.14)): Addressed @jkczyz comment Changes: 1. Renamed `Request` and `Response` to `Ping` and `Pong` to better suit their new roles of being each other's response....
Updated from [pr2996.14](https://github.com/shaavan/rust-lightning/commits/pr2996.14) to [pr2996.15](https://github.com/shaavan/rust-lightning/commits/pr2996.15) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.14..pr2996.15)): Addressed @jkczyz comment Changes: 1. Introduce the add_reply_path boolean as part of expectations. This allows saving up on a mutex variable and keeps things...
Updated from [pr2996.15](https://github.com/shaavan/rust-lightning/commits/pr2996.15) to [pr2996.16](https://github.com/shaavan/rust-lightning/commits/pr2996.16) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.15..pr2996.16)): Addressed @jkczyz comments 1. Refactor the function and improve naming structs for TestCustomMessageHandler. 2. Improve the test readability by properly structuring and separating success...
Updated from [pr2996.16](https://github.com/shaavan/rust-lightning/commits/pr2996.16) to [pr2996.17](https://github.com/shaavan/rust-lightning/commits/pr2996.17) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.16..pr2996.17)): Changes: 1. Rebase on main
@jkczyz, @TheBlueMatt A gentle ping! :)
Updated from [pr2996.17](https://github.com/shaavan/rust-lightning/commits/pr2996.17) to [pr2996.18](https://github.com/shaavan/rust-lightning/commits/pr2996.18) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.17..pr2996.18)): Addressed @jkczyz comment Update: 1. Rebase on main. 2. Update the `create_blinded_path` function and `BlindedPath::new_for_message` to match the API change. 3. Expanded `handle_onion_message_response` docs.
Updated from [pr2996.18](https://github.com/shaavan/rust-lightning/commits/pr2996.18) to [pr2996.19](https://github.com/shaavan/rust-lightning/commits/pr2996.19) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.18..pr2996.19)): Addressed @jkczyz's comment: Changes: 1. Removed the redundant commented code. 2. Applied nit fixes to docs. @jkczyz: > BTW, please avoid rebasing mid-review as...