Shashwat Vangani
Shashwat Vangani
Updated from aa6229e5d2bebe20d3e8e3eded8ff3ad7841bfcb to 0c364201a2e16355cd6424c6137761c7967db4e0([pr457.04](https://github.com/shaavan/gui/tree/pr457.04) -> [pr457.05](https://github.com/shaavan/gui/tree/pr457.05)) Addressed @hebasto and @randymacmilan comments - Removed custom color of the added splitter - Moved `childrenCollapsible=False` to debugwindow.ui file. - Removed auto-generated changes...
Updated from 0c364201a2e16355cd6424c6137761c7967db4e0 to 5a9bdce0ad753919522b8bc627c1c12d92d7cae8 ([pr457.05](https://github.com/shaavan/gui/commits/pr457.05) -> [pr457.06](https://github.com/shaavan/gui/commits/pr457.06), [diff](https://github.com/shaavan/gui/compare/pr457.05..pr457.06)) Addressed @hebasto comment Changes: - Rebased PR over the current master. - Separated adding of **banTable** and **tableSplitter** in separate commits....
@luke-jr, @hebasto. Just a reminder. One of the alternatives of this PR, #317, has been merged. So, can this PR be closed?
It would be great to give the example of some use cases for allowing editing of labels in the receiving tab. And wouldn't allowing editing of receive label encourage reusing...
Thanks, @vostrnad, for pointing out the potential flaws in my review. Yes, I did use ChatGPT to structure my thoughts on the “problems with P2PK” in a coherent fashion, but...
Thanks, @vostrnad, for helping me bring clarity to my understanding. I understand that my points were made based on my limited knowledge surrounding the discussions around P2TR. And also, I...
Let me try giving it a shot!
Updated from [pr3065.01](https://github.com/shaavan/rust-lightning/commits/pr3065.01) to [pr3065.02](https://github.com/shaavan/rust-lightning/commits/pr3065.02) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3065.01..pr3065.02)): Addressed @TheBlueMatt comment: Changes: 1. Introduce a new constant `TICKS_PER_MINUTE` and use it as the multiplying factor for other constants. This will allow us...
Hi @TheBlueMatt, I’ve been diving into the approach you suggested and I have a few questions I could use your guidance on: 1. When retrying, should we be going through...
I've updated #3010 with the new approach (see [comment](https://github.com/lightningdevkit/rust-lightning/pull/3010#issuecomment-2158324567)). Since we no longer need a sub-minute timer with this new method, this PR has become redundant. So, I'll go ahead...