Shashwat Vangani

@joostjager > Main thing I try to understand is how the hmac authentication of the dummy hops helps with a time attack. Isn't this accomplishing the exact opposite? Peeling is...

> Okay, indeed, I see that an attacker crafting dummy hops with a bad authentication code can't learn anything from that. It will fail immediately, and they already knew it...

**Updated from** [pr3728.06](https://github.com/shaavan/rust-lightning/commits/pr3728.06) to [pr3728.07](https://github.com/shaavan/rust-lightning/commits/pr3728.07) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3728.06..pr3728.07)): Addressed @jkczyz comments Changes: 1. Rename `get_inbound_payment_key` -> `get_expanded_key` and expanded documentation.

**Updated from** [pr3728.07](https://github.com/shaavan/rust-lightning/commits/pr3728.07) to [pr3728.08](https://github.com/shaavan/rust-lightning/commits/pr3728.08) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3728.07..pr3728.08)): Changes: 1. Rebase on main

Right now, this PR is a proof of concept for the approach—it introduces a basic set of utilities to move a significant chunk of Offers-related code out of `ChannelManager`. ####...

@TheBlueMatt, @jkczyz A gentle ping! :)

**Updated from** [pr3639.01](https://github.com/shaavan/rust-lightning/commits/pr3639.01) to [pr3639.02](https://github.com/shaavan/rust-lightning/commits/pr3639.02) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3639.01..pr3639.02)): Addressed @jkczyz comments Changes: - Implement `chain::Listen` of OffersMessageFlow, to allow keep the `highest_seen_timestamp` synced.

@TheBlueMatt > Were we going to move most of the OffersMessageHandler logic into flow.rs? Yes, that’s the goal! For this version, I’ve primarily abstracted out the `Bolt12` payers/builders from `ChannelManager`....

**Updated from** [pr3639.02](https://github.com/shaavan/rust-lightning/commits/pr3639.02) to [pr3639.03](https://github.com/shaavan/rust-lightning/commits/pr3639.03) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3639.02..pr3639.03)): Addressed @jkczyz and @TheBlueMatt comments **Changes:** - Completed the Flow approach by incorporating changes across all relevant functions, handlers, and queues. **Points of notice:**...

Also, a gentle ping @TheBlueMatt and @jkczyz — thank you so much for all your inputs and ideas! Really grateful for them. Looking forward to your thoughts on the completed...