Shashwat Vangani comments

Results 159 comments of


                                            Shashwat Vangani

refactored `payment_parameters_from_zero_amount_invoice` to `amount-less`

I was thinking maybe something simple like this may also work ```diff /// Builds the necessary parameters to pay or pre-flight probe the given zero-amount -/// [`Bolt11Invoice`] using [`ChannelManager::send_payment`] or...

Use unique per-node "node_counter"s rather than a node hashmap in routing

CI's unhappy. Looks like there's some error in the code

Allow Asynchronously responding to Invoice Request

Updated from [pr3318.01](https://github.com/shaavan/rust-lightning/commits/pr3318.01) to [pr3318.02](https://github.com/shaavan/rust-lightning/commits/pr3318.02) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3318.01..pr3318.02)): Changes: 1. Rebase on main to resolve merge conflicts and fix CI.

Allow Asynchronously responding to Invoice Request

Updated from [pr3318.02](https://github.com/shaavan/rust-lightning/commits/pr3318.02) to [pr3318.03](https://github.com/shaavan/rust-lightning/commits/pr3318.03) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3318.02..pr3318.03)): Addressed @jkczyz comments Changes: 1. Update Responder to be required field. 2. Update InvoiceRequestReceived Docs. 3. Update condition check when the Custom Amount should...

Allow Asynchronously responding to Invoice Request

#3525 introduces `Bolt12Assessor`, allowing for custom logic to assess `InvoiceRequest` before handling, which serves as an alternative to this PR. Given this, I am closing this PR in favor of...

Improve privacy for Blinded Message Paths using Dummy Hops

**Updated from** [pr3728.01](https://github.com/shaavan/rust-lightning/commits/pr3728.01) to [pr3728.02](https://github.com/shaavan/rust-lightning/commits/pr3728.02) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3728.01..pr3728.02)): Addressed @joostjager comments Changes: 1. DRYed up the code. 2. Update logic so that we bring randomness to the number of blinded hops we...

Improve privacy for Blinded Message Paths using Dummy Hops

**Updated from** [pr3728.02](https://github.com/shaavan/rust-lightning/commits/pr3728.02) to [pr3728.03](https://github.com/shaavan/rust-lightning/commits/pr3728.03) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3728.02..pr3728.03)): Addressed @valentinewallace comments Changes: 1. Remove the rand dependency, and instead using entropy source for random dummy hop count. 2. Updated code to not...

Improve privacy for Blinded Message Paths using Dummy Hops

**Updated from** [pr3728.03](https://github.com/shaavan/rust-lightning/commits/pr3728.03) to [pr3728.04](https://github.com/shaavan/rust-lightning/commits/pr3728.04) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3728.03..pr3728.04)): Addressed @valentinewallace, @joostjager comments 1. Introduce new Dummy ControlTlvs that allows add authentication to each dummy hop, so that we can verify the hop...

Improve privacy for Blinded Message Paths using Dummy Hops

**Updated from** [pr3728.04](https://github.com/shaavan/rust-lightning/commits/pr3728.04) to [pr3728.05](https://github.com/shaavan/rust-lightning/commits/pr3728.05) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3728.04..pr3728.05)): Addressed @valentinewallace, @joostjager comments Changes: 1. Rebase on main to resolve merge conflicts.

Improve privacy for Blinded Message Paths using Dummy Hops

**Updated from** [pr3728.05](https://github.com/shaavan/rust-lightning/commits/pr3728.05) to [pr3728.06](https://github.com/shaavan/rust-lightning/commits/pr3728.06) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3728.05..pr3728.06)): Addressed @joostjager comments Changes: 1. Renamed `dummy_tlvs` -> `dummy_tlv`. 2. Expanded Documentation. 3. Fix number of added dummy hops (from 1-5, to 0-5), to...