Shashwat Vangani

Results 159 comments of Shashwat Vangani
trafficstars

**Updated from** [pr3639.03](https://github.com/shaavan/rust-lightning/commits/pr3639.03) to [pr3639.04](https://github.com/shaavan/rust-lightning/commits/pr3639.04) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3639.03..pr3639.04)): Addressed @TheBlueMatt and @jkczyz comments Changes: 1. Introduce new commits, that updates `OffersMessageFlow` to be parameterised over `MessageRouter`, and `Router`. 2. This allows remove...

**Updated from** [pr3639.04](https://github.com/shaavan/rust-lightning/commits/pr3639.04) to [pr3639.05](https://github.com/shaavan/rust-lightning/commits/pr3639.05) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3639.04..pr3639.05)) Addressed @jkczyz’s comments. ### Changes 1. Cleaned up commit history. 2. Moved all `MessageContext` initiation in `ChannelManager` to `Flow`. 3. Removed the `Flow` trait...

**Updated from** [pr3639.05](https://github.com/shaavan/rust-lightning/commits/pr3639.05) to [pr3639.06](https://github.com/shaavan/rust-lightning/commits/pr3639.06) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3639.05..pr3639.06)) Addressed @jkczyz’s comments. - Squashed commit to make it easier to understand moved changes. - Move Flow construction out of the ChannelManager

@jkczyz > For now, we can probably move the Clone trait bound to only be on a separate impl block for ChannelManager's constructor, leaving the other impl blocks as they...

**Updated from** [pr3639.06](https://github.com/shaavan/rust-lightning/commits/pr3639.06) to [pr3639.07](https://github.com/shaavan/rust-lightning/commits/pr3639.07) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3639.06..pr3639.07)) Addressed @valentinewallace comments 1. Rebase on main.

**Updated from** [pr3639.07](https://github.com/shaavan/rust-lightning/commits/pr3639.07) to [pr3639.08](https://github.com/shaavan/rust-lightning/commits/pr3639.08) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3639.07..pr3639.08)) Addressed @TheBlueMatt and @jkczyz comments Changes: 1. Temporarily commented out the the `secp_ctx` seeded randomisation, to prevent test failure. 2. Removed `chain::Listen` implementation from...

**Updated from** [pr3639.08](https://github.com/shaavan/rust-lightning/commits/pr3639.08) to [pr3639.09](https://github.com/shaavan/rust-lightning/commits/pr3639.09) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3639.08..pr3639.09)) Changes: 1. Fix CI

**Updated from** [pr3639.09](https://github.com/shaavan/rust-lightning/commits/pr3639.09) to [pr3639.10](https://github.com/shaavan/rust-lightning/commits/pr3639.10) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3639.09..pr3639.10)) Addressed @jkczyz and @TheBlueMatt offline comments. ### Changes: 1. **Avoided field repetition** in `OffersMessageFlow` and `ChannelManager` by no longer duplicating commonly shared fields (`MessageRouter`,...

**Updated from** [pr3639.10](https://github.com/shaavan/rust-lightning/commits/pr3639.10) to [pr3639.11](https://github.com/shaavan/rust-lightning/commits/pr3639.11) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3639.10..pr3639.11)) Changes: 1. Rebase on main, to resolve merge conflicts.

**Updated from** [pr3639.11](https://github.com/shaavan/rust-lightning/commits/pr3639.11) to [pr3639.12](https://github.com/shaavan/rust-lightning/commits/pr3639.12) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3639.11..pr3639.12)) Addressed @valentinewallace comments Changes: 1. Cleaned-up code and expanded documentation.