Shashwat Vangani

Results 159 comments of Shashwat Vangani
trafficstars

Updated from [pr2996.01](https://github.com/shaavan/rust-lightning/commits/pr2996.01) to [pr2996.02](https://github.com/shaavan/rust-lightning/commits/pr2996.02) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.01..pr2996.02)): Update: 1. Synced with base PR (#2907) to solve merge conflicts.

Updated from [pr2996.02](https://github.com/shaavan/rust-lightning/commits/pr2996.02) to [pr2996.03](https://github.com/shaavan/rust-lightning/commits/pr2996.03) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.02..pr2996.03)): Addressed @jkczyz comments: Updates: 1. Address nit comments. 2. Expanded return type of `handle_onion_message_response`. This change allows access to the success/failure status of sending...

Updated from [pr2996.03](https://github.com/shaavan/rust-lightning/commits/pr2996.03) to [pr2996.04](https://github.com/shaavan/rust-lightning/commits/pr2996.04) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.03..pr2996.04)): Updates: 1. Rebase on main, to resolve conflicts post #2907 merge.

Updated from [pr2996.04](https://github.com/shaavan/rust-lightning/commits/pr2996.04) to [pr2996.05](https://github.com/shaavan/rust-lightning/commits/pr2996.05) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.04..pr2996.05)): Addressed @TheBlueMatt, @jkczyz comments Updates: 1. Expanded `respond()`, and `respond_with_reply_path()` documentation. 2. Updated test to check if we got the expected variant of SendSuccess,...

Updated from [pr2996.05](https://github.com/shaavan/rust-lightning/commits/pr2996.05) to [pr2996.06](https://github.com/shaavan/rust-lightning/commits/pr2996.06) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.05..pr2996.06)): Addressed @jkczyz comments Updates: 1. Simplify the respond, and respond_with_reply_path docs to make them concise. 2. Simplify the result check in the added test....

Updated from [pr2996.06](https://github.com/shaavan/rust-lightning/commits/pr2996.06) to [pr2996.07](https://github.com/shaavan/rust-lightning/commits/pr2996.07) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.06..pr2996.07)): Updates: 1. Rebase on main, to fix ci failures.

Updated from [pr2996.07](https://github.com/shaavan/rust-lightning/commits/pr2996.07) to [pr2996.08](https://github.com/shaavan/rust-lightning/commits/pr2996.08) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.07..pr2996.08)): Addressed @TheBlueMatt and @jkczyz comments Changes: 1. Expanded docs for `respond` and `respond_with_reply_path` so that there purpose is more clearly explained. 2. Expand log...

Updated from [pr2996.08](https://github.com/shaavan/rust-lightning/commits/pr2996.08) to [pr2996.09](https://github.com/shaavan/rust-lightning/commits/pr2996.09) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.08..pr2996.09)): Addressed @jkczyz comment Update: 1. Fix grammatical error. 2. Update logging so that a string will not be created in case it is not...

Updated from [pr2996.09](https://github.com/shaavan/rust-lightning/commits/pr2996.09) to [pr2996.10](https://github.com/shaavan/rust-lightning/commits/pr2996.10) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2996.09..pr2996.10)): Addressed @jkczyz comments Changes: 1. Corrected a nit, `reply_path` -> `reply path` 2. Expanded SendError::PathNotFound documentation as it can also be triggered when we...