Zsolt Dollenstein comments

Results 144 comments of


                                            Zsolt Dollenstein

Parse error found with Hypothesmith

Nice!

Parse error found with Hypothesmith

FWIW this is also a bug in upstream lib2to3. You might want to report it on http://bugs.python.org/

Upcoming aiohttp 4.0 is breaking our test suite with a new deprecation warning

Nah that mypy primer test should probably do something more trivial than running our test suite. Like maybe running `black --check .`

Better quotes normalisation with triple quotes

I agree both of your examples are way more readable with single quotes, so I'm generally supportive of this change (not a shocker given my original implementation in #75 handled...

Line too long: Lambda with many parameters

What formatting do you suggest?

Only enforce blank line separation between functions and classes at the same level of nesting

I support this, @ambv what do you think?

Black's public API

In general, maybe we should take a moment to consider the APIs we're "setting in stone" for the first stable release in April.

Remove trailing spaces in f-string expressions

Hey, thanks for taking a stab at this. I have two concerns: 1. This only solves the problem partially. prefix and postfix spaces will be stripped, but the rest of...

convert f-string with nothing to interpolate to regular string

Wouldn't a linter be a better place for this type of transformation? Flake8 already flags this, but fails to offer an autofix - which IMO is why it's even considered...

Black breaks comment formatting for slurm/pbs cluster directives.

I think that's the best solution I've seen so far, even though it would make Black produce code that's technically not PEP-8 compliant. But maybe it's the pragmatic choice.