Zsolt Dollenstein

icon indicating an email [email protected]

icon company @facebook icon location London, UK

Results 144 comments of Zsolt Dollenstein

Indentation wart when removing an Arg from a Call - is whitespace being represented in the right place?

Yes, this is because the whitespace between `(` and `arg1` is owned by the function call node. You can see this yourself if you go to https://libcst.me/, paste your example:...

Add data to nodes

Normally I'd recommend metadata providers for this; while they're a bit cumbersome, they essentially let you store arbitrary data keyed by the identity of a `CSTNode`.

A way to silence "Failed to determine module name"?

Sounds like the `repo_root` you're passing in is incorrect

Fix generating invalid trailing commas in import statements

Thanks for your contribution! This all looks good to me. The logic will also need to be ported to https://github.com/Instagram/LibCST/blob/46509dd5e119ab3df7b53ef4eb281bde72a30409/native/libcst/src/nodes/statement.rs#L782 before merging.