Zsolt Dollenstein

Results 144 comments of Zsolt Dollenstein

Looks like black is failing to put parenthesis in there. Smells like a bug, thanks for reporting! May be related to #275 and #330

(Btw I'm running 17.8.0) which is on PyPI but can't see the tag in this repo

This has been fixed in `blib2to3` in Black. Maybe I should split it out into its own module, seeing how there's not much interest in backporting changes like https://github.com/python/cpython/pull/6586 and...

Interesting, so this example only works when you pass in a `MetadataWrapper` as `findall()`'s first parameter, so: ``` import libcst as cst import libcst.matchers as m from libcst.metadata import PositionProvider...

Yep, all of this makes sense to me. Happy to accept a PR that will do this. We should roll this out as a minor version bump and be loud...

If I understand this correctly, you're proposing a codemod that replaces `foo = foo + bar` style assignments with `foo += bar`? That's totally doable with LibCST and if you...

Although maybe #156 will help with this.

This is a tricky one - it's unclear which node's responsibility should include validating the presence of these required parens.

I'm happy to accept a PR for this. Please make sure to document the limitations (inability to configure how whitespace is rendered) and the workaround (make a `Module` object with...

Do failures look decent? I'm mainly looking for if a failure message includes the inputs or at least some label. How does this play with pyre?