Zsolt Dollenstein comments

Results 144 comments of


                                            Zsolt Dollenstein

[rfc] Add simple snapcraft.yaml to package CLI

I also think option 2 would make the most sense. I can make a followup PR to implement it

pyright + `or` in generic type annotations gives unknown type

I think Pyright's behavior is correct here; essentially we're running into the [incompatible changes](https://peps.python.org/pep-0604/#incompatible-changes) section in PEP 604. Other than changing the matcher syntax to use something other than `|`...

Implement PEP 696 (defaults for type params)

3.13.0 beta 1 is expected to come out next week. @thereversiblewheel need help? :)

Implement PEP 696 (defaults for type params)

I'll try and get a new libcst release while on the pycon sprints now that #1141 has been merged

Make nodes fields filtering process public

Gotta fix the type errors and this is good to go.

fix: all references are not ignored

Gotta fix the type errors (looks like `Name.__init__` needs updating too) and this is good to go!

Fixit can be incredibly slow. Are there any recommendations available for profiling checks?

Happy to merge a keke PR for libcst, I was about to release a new version tomorrow but can wait a bit

Stack overflow when parsing an expression

FWIW CPython also chokes on this input: ``` ❯ py -m py_compile 'huge.txt' Sorry: RecursionError: maximum recursion depth exceeded during compilation ```

Stack overflow when parsing an expression

Fair enough. If anyone's interested in tackling this, here are a bunch of pointers: There's best-effort recursion depth checking that's defined here: https://github.com/Instagram/LibCST/blob/e9bad94d5868ba5a3919cc34e26665d40cdf9f91/native/libcst/src/parser/grammar.rs#L88 It's checked in a couple of places,...

`FlattenSentinel` can't be used as return type annotation

See #906 also for `FlattenSentinel`-related typing bugs