Zsolt Dollenstein comments

Results 144 comments of


                                            Zsolt Dollenstein

Show how @parameterized could replace @data_provider

> Generally I question the value of implementing a parameterized testing in libcst (vs a standalone lib) Fully agree. Alright, I'm on board :)

`Assign.value` has incorrect type annotation

Or maybe we should just make `StarredElement` subclass `BaseExpression` since it can also appear in `yield`, `return`, and maybe other statements

RemoveUnusedImports codemod incorrectly removes this

OTOH the codemod also removes this import: ``` from a import b class X: b = 1 c = b() ``` Because the imported `b` clashes with the class-local `b`...

Using inverse of matcher errors for visit decorators

I have to admit I'm not intimate with the matcher API, but I'd expect something like your use case to work. Marking this issue as a bug

Fix type of `evaluated_value` on string

Thanks for the PR; this seems reasonable to me but let's fix the type errors this introduces before merging. There are [instructions in the readme](https://github.com/Instagram/LibCST/blob/main/README.rst#type-checking) about how you can set...

Fix type of `evaluated_value` on string

Let me see if I can get you some help for that Pyre issue. About the maturin build problem: that's interesting, I've never seen that issue before (admittedly, I don't...

Warn when autoformatter clobbers files

Try `formatter: ["black", "-"]` ;)

Warn when autoformatter clobbers files

Yeah I think that's a good improvement, but I'm not sure it would've helped in your case (you figured this out yourself)

TypeInferenceProvider gen_cache() raises `[Errno 7] Argument list too long`

@jimmylai that would mean `TypeInferenceProvider`'s API need to be documented to say "don't pass in a lot of paths here, because we're going to shell out with all of them...

Extend docs for qualified names by new features from #477

For your reviewing pleasure: https://9786-200896124-gh.circle-artifacts.com/0/doc/metadata.html#libcst.metadata.Scope.get_qualified_names_for