Zsolt Dollenstein comments

Results 144 comments of


                                            Zsolt Dollenstein

Python 3.13.0b1: Segmentation fault when running tests

I'm having trouble building a `cffi` wheel using 3.13.0b1 which is a build dependency of the rust bits. How did you manage to get it running? Specifically, after setting `HATCH_PYTHON`...

Python 3.13.0b1: Segmentation fault when running tests

This now passes with 3.13.0b3

Certain codemod decorator matchers crash in parallel_exec_transform_with_prettyprint

I think this will be fixed by #1204.

libcst depends on fixit, and fixit depends on libcst

Closing this as #1142 has been updated to mention `git fetch --tags`

`AsName.name` has incorrect type annotations

> Introduce a second, `WithAsName` class. I think this is the more correct approach, but can we make it a backwards compatible change at least for valid code?

test_parse_error for native parser

👋 1. Yes! IIRC that is the only place where parse errors for the entire parser are tested. Before I answer 2, let me give some context: when writing the...

[support] running test suite doesn’t find libcst.native

I'm not really sure how to help here. The tests work just fine upstream, my only guess is the `.so` file is not actually in the right place or something...

Upgrade pyo3 to 0.22

This looks good to me, thanks! I need some time before I can merge this to figure out what other things need upgrading to 0.22 internally at Meta

Upgrade pyo3 to 0.22

Alright, let's do this. Thanks for contributing @jelmer!

MatchIfTrue lambdas used in decorator matchers in VisitorBasedCodemodCommand hit pickle errors on large codebase

Hmm I suppose the entire visitor/codemod needs to be pickleable when running it against multiple files, but the matchers accepting callbacks definitely encourage lambdas, so I'd support a PR to...