Zsolt Dollenstein comments

Results 144 comments of


                                            Zsolt Dollenstein

Fix docstring of `FullRepoManager`

Thank you!

AnnAssign allows invalid whitespace around equals

Yep, looks like this is a bug. This returns the broken source code ``` from libcst import AnnAssign, Annotation, AssignEqual, Name, ParenthesizedWhitespace, TrailingWhitespace, Module, SimpleStatementLine Module(body=[ SimpleStatementLine(body=[ AnnAssign( target=Name( value='foo',...

`elt` in generator expressions have incorrect type annotations

[The Python ast docs](https://docs.python.org/3/library/ast.html) say it can be any expression.

Improve ParserSyntaxError messages for parse_expression and parse_statement

LibCST would need to try and re-parse the input as a module when there's a syntax error caught by `parse_{expression,statement}`. We'd need to consider the performance implications too

Support PEP-614 - relaxed grammar restrictions on decorators

So this is already supported by the native parser (currently enabled by setting the `LIBCST_PARSER_TYPE` env var to `native`), but validation rules on the CST nodes disallow it. Needs a...

Drop use of libcst.testing.*

Maybe add a type stub for parameterized, so pyre doesn't complain about a missing `expand` function?

`_INDENT_RE` is too narrow - `'\x0c '` is strange but valid indent whitespace

uhhhh... thanks? :) 🥇

`ValueError` when using `FullyQualifiedNameProvider`

Cc @lpetre

Add pre-commit hooks configuration

I think [this would be a great place](https://fixit.readthedocs.io/en/latest/getting_started.html#Enforcing-Custom-Rules) to add the docs (as a separate section)

TypeInferenceProvider using another tool than pyre - Jedi

At a glance, this is really cool! I can take a deeper look a bit later