Yacin Tmimi

Results 716 comments of Yacin Tmimi

Thanks. Yeah, rustfmt isn't expecting to find a comment between the macro's name `println`, and the `!`. My recommendation would be not to put your comment there.

Thanks for the report. confirming I can reproduce the issue with rustfmt 1.8.0-nightly (fd0ea742f8 2025-04-12). I believe the issue is that we're forgetting to take the attribute into account when...

> [!IMPORTANT] > This change was reverted in https://github.com/rust-lang/rustfmt/pull/6595 because `style-edition=2024` had already been released before we could defer the change to `style-edition=2027`. --- Reverted Change ### Break function return...

TODO: Document https://github.com/rust-lang/rustfmt/pull/6572

TODO: Document https://github.com/rust-lang/rustfmt/pull/6594

I'm definitely in favor of stabilizing this! I'm also interested in learning more about the new name / variants you're thinking of.

Thanks for the report. Confirming I can reproduce this with rustfmt 1.7.1-nightly (40f5075269 2024-08-05)

Also marking this as a bug because it's not idempotent.

We could try adding a new unstable option for this. Maybe named something like `precise _capture_order` with three variants `Preserve` (default), `First`, and `Last`.

I'm not sure how we should move forward here. I'm going to mark this one as blocked for now. If you could, please file an issue with [team-style](https://github.com/rust-lang/style-team/issues) to see...