Yacin Tmimi
Yacin Tmimi
Thank you! I ran into this exact issue and was really struggling to figure out why the example wasn't working. I totally agree that a note to the reader would...
> why did L384 do such a double check? That decision predates my time with the project. My best guess is that there was a time when both were necessary...
@pan93412 I noticed that this PR also resolves #5568 so I added a test case on your branch to validate that
For anyone interested in working on this here's a little bit of what I found: The [`Rewrite` impl for `ast::FieldDef`](https://github.com/rust-lang/rustfmt/blob/38659ec6ad5f341cf8eb3139725bf695872c6de7/src/items.rs#L1724-L1728) is implemented by calling `rewrite_struct_field`. To calculate the `field_str`, `rewrite_struct_field`...
@jmj0502 Normally changing existing tests isn't something we want to do, but in this case it seems like the bug slipped into those tests. I think it should be fine...
linking #3286
@blyxyas PRs for doc improvements are always welcome 😁
@blyxyas no worries. I also couldn't have told you what it did before looking into it. From what I can tell it's meant to let you control the width at...
Thanks for this. A slightly smaller reproducible example is: ```rust impl Phase for Updating { const FAIL: &'static str = ""; #[rustfmt::skip] fn to_style(&self, template: &str) {} } ``` Although...
@calebcartwright were you referring to #4706?