Yacin Tmimi
Yacin Tmimi
Thanks for clarifying. That might be easier said than done. As you've noted, rustfmt doesn't take the source layout into account when rewriting AST nodes.
The way rustfmt preserves newlines between AST nodes is actually fairly simple and doesn't require keeping track of any layout information from the source code. It does however peek back...
> This is only true in a narrow case. It's not every time. In practice, the opposite happens, and `rustfmt` can force identical AST nodes to look completely different: >...
It's the use of the `ignore` attribute. rustfmt treats that as "don't format this code".
Linking the tracking issue for `wrap_comments` #3347
This is a case where the macro fails to parse, and I assume that since it's formatted on one line and the closure only contains a single item rustfmt really...
@kuqmua thanks for the report. What version of rustfmt were you using? You can find this out by running `rustfmt --version`.
@lukewilson2002 I suggested those changes not @chrisduerr 😅, but I'm glad to see that you've picked them up for this PR. In addition to the test case you've added here...
After some additional investigation I noticed that `compute_budgets_for_params` seems to be off when there's a where_clause; specifically on how it updates the `used_space` variable. This error causes the params to...
@lukewilson2002 Thanks for expanding on the test cases! Let's keep the examples that you've added. I think it's still valuable to show cases where things will wrap. To cover our...