Yacin Tmimi

I think the "off by one" issue you've described here might be a distinct issue, at least I couldn't find anything for it with a quick search in the back...

Personally I'd want to limit the scope of this to just the "off by one" error described above. I did a little digging into this and I think I tracked...

Thanks for the report. I took a look at the [1.7.1 CHANGELOG](https://github.com/rust-lang/rustfmt/blob/master/CHANGELOG.md#171-2024-06-24), but it's unclear to me which of those changes, if any, caused this. Also, I'm unable to reproduce...

Thanks for digging into this! That helped me remember that https://github.com/rust-lang/rustfmt/issues/6203 mentioned there would be an impact to non-ascii unicode chars, but I don't think we expected this to impact...

Agreed that neither `0` nor `1` are correct. Getting `unicode_str_width` to calculating the precise width of any given tab character while rustfmt is rewriting your code will be challenging. It'll...

Thanks! confirming that I can reproduce this behavior with rustfmt 1.8.0-nightly (fd0ea742f8 2025-04-12) (built from source). Running `cargo run --bin rustfmt -- --style-edition={2015|2018|2021}` all remove the trailing whitespace, while running...

@jblachly you're issue is off topic. It's a duplicate of #3591 and other linked issues. rustfmt won't format binary expressions if they contain comments in the because they would otherwise...

Please open a PR for this if you have any suggestions for clarifying the docs.

I'm fairly certain that `rewrite_let_else_block` and `rewrite_explicit_self` are only used within these functions so it's likely easier to update their signatures now, while `combine_str_with_missing_comment` is used throughout the codebase and...

@ding-young when you have a chance can you squash the commits and rebase this PR to bring it up to date