Yacin Tmimi

Results 716 comments of Yacin Tmimi

The rustfmt team doesn't use Discord that much these days. You can reach out here, though the best place to ask about rustfmt development related questions is the `t-rustfmt` channel...

Thanks for the report. This feels related to https://github.com/rust-lang/rustfmt/issues/5874

Looking into this a little more it seems this ins't just related to HTML blocks. It's also paragraphs, and presumably anything else that's separated from the `:` by two newlines....

One more test case. [Here's how pandoc handles it](https://pandoc.org/try/?params=%7B%22text%22%3A%22Definition%5Cn%5Cn%3A%5Cn%5Cn++Some+text%22%2C%22to%22%3A%22html5%22%2C%22from%22%3A%22commonmark_x%22%2C%22standalone%22%3Afalse%2C%22embed-resources%22%3Afalse%2C%22table-of-contents%22%3Afalse%2C%22number-sections%22%3Afalse%2C%22citeproc%22%3Afalse%2C%22html-math-method%22%3A%22plain%22%2C%22wrap%22%3A%22auto%22%2C%22highlight-style%22%3Anull%2C%22files%22%3A%7B%7D%2C%22template%22%3Anull%7D). ```markdown Definition : Some text ``` Events from running `cargo run -- -D -e` ``` 0..17: Start(DefinitionList) 0..11: Start(DefinitionListTitle) 0..10: Text(Borrowed("Definition"))...

const block formatting was updated in the [1.7.1](https://github.com/rust-lang/rustfmt/blob/master/CHANGELOG.md#171-2024-06-24) release to address a different bug: https://github.com/rust-lang/rustfmt/pull/6173. It's unfortunate that the formatting for const blocks with outer attributes was impacted because of...

Confirming I can reproduce this when building from source using rustfmt 1.7.1-nightly (7cdb426c 2024-07-15). Linking the tracking issue for `imports_granularity` (https://github.com/rust-lang/rustfmt/issues/4991)

> Ran into another one of these: > >```rust >trait Trait // comment >where > T: Clone, >{ >} >``` @martin-t I'm pretty sure this is a duplicate of #4649

@NishantJoshi00 I don't think anyone has picked this up. If you're interested in working on it you can comment `@rustbot claim` to assign yourself.

> 1. We can consider changing the type definition of RewriteResult to something like: pub(crate) type RewriteResult = Result; This, while not affecting most of the code, could help solve...

@tgross35 I think a similar issues has been reported before but I can't find it in the backlog right now. Probably best to open up a new issue for this...