Yacin Tmimi

Results 716 comments of Yacin Tmimi

@lbfalvy can you please get this down to a minimal example that can be used to reproduce the error. Also, it would be good to know the exact version of...

Because this issue involves tabs, I think this is related to https://github.com/rust-lang/rustfmt/issues/4968#issuecomment-949461340

From local testing with rustfmt 1.8.0-nightly (d97c4fb3e2 2025-01-13) this snippet from https://github.com/rust-lang/rustfmt/issues/6442#issuecomment-2587385011 still panics with `hard_tabs=true`

I see. Either way, the MCVE you provided still panics, and I think that's a good enough reason to keep the issue open

Just to clarify `annotate-snippets` used to take character offsets. [As of a more recent release it uses byte offsets](https://github.com/rust-lang/rustfmt/pull/6391#issuecomment-2471781526). I Agree with your assessment of the underlying issue though.

running `rustfmt --print-config default` is exhaustive, and even includes the default for nightly only options that you can't set on stable. I'm not sure what you mean about overwriting the...

Thanks for reaching out. If I understand correctly, you'd like an option to enforce a consistent number of blank lines between various control flow constructs. Let me know if I've...

You might want to familiarize yourself with how functions get rewritten. That starts in `FmtVisitor::visit_fn`. `visit_block` is called next, and internally that makes a call to `walk_block_stmts`. There's more to...

@kornelski I'm not sure if it'll help in all cases, but maybe some of rustfmt's more granular width configurations could help you out here. I'm linking to [use_small_heuristics](https://rust-lang.github.io/rustfmt/?version=v1.7.1&search=#use_small_heuristics), which links...