isort icon indicating copy to clipboard operation
isort copied to clipboard

Repo branches are getting out of control

Open kurtmckee opened this issue 10 months ago • 0 comments

There are 50 branches in-repo, many of which are associated with PRs that have merged or been closed.

As an initial step, I recommend deleting branches associated with PRs that have merged, been closed, or are otherwise unnecessary to keep.

Then, I recommend enabling automatic head branch deletion in the repository settings:

⚙ Settings > General > Automatically delete head branches

Image

kurtmckee avatar Mar 06 '25 15:03 kurtmckee

Thanks for the report. confirming I can reproduce the issue with rustfmt 1.8.0-nightly (fd0ea742f8 2025-04-12).

I believe the issue is that we're forgetting to take the attribute into account when rewriting the variadic parameter: https://github.com/rust-lang/rustfmt/blob/bf5f0eac9bf2d0bca50d3ba6a5c0548e713e6a5d/src/items.rs#L2345

I think this could be fixed with the following change, thought some additional test cases would be needed to verify that.

-            self.ty.rewrite_result(context, shape)
+            combine_strs_with_missing_comments(
+                context,
+                &param_attrs_result,
+                &self.ty.rewrite_result(context, shape)?,
+                span,
+                shape,
+                !has_multiple_attr_lines && !has_doc_comments,
+            )

ytmimi avatar Jun 05 '25 01:06 ytmimi