Yacin Tmimi

Improve Documentation For `single_line_if_else_max_width` in `Configurations.md` + Add Tests

3

The [`single_line_if_else_max_width`](https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#single_line_if_else_max_width) is one of many configuration options that could use some improvements to it's documentation. It would be great to: * Add code snippets to highlight the functionality this...

Fix idempotency issue when wrapping the last match arm in a block

4

Fixes #5193 The issues was related to the interaction between two differnt configuration options when applied to the last match arm. * ``trailing_comma = Never`` * ``match_block_trailing_comma = true`` Previously,...

Add `fn_call_layout` configuration option

35

Closes #5218 The `fn_call_layout` was added to give users more control over how function calls are formatted. The values are identical to those for `fn_args_layout`, which is a stable option...

Add GitHub Action to test master rustfmt formatting vs a feature branch

2

This new action is intended to help us maintainers determine when feature branches cause breaking formatting changes by running rustfmt (master) and the feature branch on various rust repositories. Over...

Closes #4635 It's unclear which commit resolved this, but the original issue cannot be reproduced.

Updated how nested function calls are overflowed

2

Fixes #5356 I feel like there's got to be a simpler way to handle this, so any recommendations on how we can update the implementation are greatly appreciated. I noticed...

Backport 4236

2

Read the original file for comparing/detecting newline (#4236) Closes #4097 The code base diverged enough where a simple cherry-pick wasn't possible, but implementing the logic to read the input file...

Use `blank_lines_*` to control newlines between module level attrs

3

Closes #4082 Now semantic meaning created by grouping attributes into "paragraphs" is maintained. Setting `blank_lines_*` will not add blank lines between module level attributes if they didn't already exist in...

Remove each comment's leading whitespace in `comment::rewrite_comment`

2

Fixes #5391 Previously, leading whitespace at the start of custom comments (`CommentStyle::Custom`) would lead `consume_same_line_comments` to not return the correct byte position for the end of the comment. This issue...

Wrap cast expr in parens when the ty ends with empty angle brackets

8

Fixes #4621 Previously rustfmt would remove empty angle brackets from cast expressions e.g. `x as i32` => `x as i32`. This lead to code that could not compile when the...