Ed Hennis

Results 183 comments of Ed Hennis

@scottschurr Ok, I'm convinced. I grabbed your commit.

Suggested squash commit message: ``` test: Env unit test RPC errors return a unique result: (#4877) * telENV_RPC_FAILED is a new code, reserved exclusively for unit tests when RPC fails...

@alloynetworks If this is ready to merge, please add the `Passed` label if you have permission, or leave a comment here indicating such.

Suggested commit message: ``` Remove zaphod.alloy.ee hub from default server list: (#4903) Remove the zaphod.alloy.ee hubs from the bootstrap and default configuration after 5 years. It has been an honor...

So it turns out that I can't push to `master` until all the CI jobs finish, and the coverage job is having upload timeouts, so I'll try that one again...

If `completed_ledgers` is ~present~ **empty**, then the server has not found and downloaded a validated ledger yet. In a sense, it is talking to itself. You need to wait until...

I think it would also be useful to have these instructions in the "What happened?" step of the clang-format.yml job.

Internal tracker: https://ripplelabs.atlassian.net/browse/RPFC-107

Per offline discussion, the merge was actually easy, so I pushed it.

Presumably, this will be ready for merge once CI passes (unless it needs to be caught up to `develop` again).