Ed Hennis
Ed Hennis
A general request: Instead of or in addition to posting screenshots, please please please copy and paste the text into a [code block](https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#quoting-code), and include both the request and the...
# Preliminary analysis: 1. The command-line currency code parser expects _only_ three letter currency codes: https://github.com/ripple/rippled/blob/develop/src/ripple/net/impl/RPCCall.cpp#L124 2. The `to_currency` function, which converts three letter string currency codes to the binary...
> Thank you @ximinez for the first analysis. My pleasure. > I think the token was issued using a JSON structure and using the actual currency code as "xSD". (through...
> Does that mean the fix for this issue might orphan non-compliant currencies (even though it allowed their creation)? Nothing will be orphaned. The transactions and ledger objects will still...
> That is interesting. xrpl.services is actually built by me and what I do is to scan a full ledger, using the ledger_data method and iterating through the markers. (directly...
Possibly trivial potential solution: change `retireFeature` in Feature.cpp to use `DefaultVote::yes` instead of `DefaultVote::no`. I implemented with `DefaultVote::no`, because I didn't want hypothetical future networks (e.g. sidechains) to unnecessarily vote...
What is the request that is generating this response? The first response looks like a validated ledger, the second response looks like the current ledger. If you request `ledger` without...
It is possible to request the `current` ledger by the numeric index. For example, this shell script demonstrates that, even though it's contrived. ``` index=$( rippled -q json ledger '{...
Some data for comparison: The Github Actions all ran simultaneously. This list indicates how long each of them took. * Linux, gcc-8 release unity: 55m 49s * Linux, clang-8 debug...
@thejohnfreeman @manojsdoshi @legleux @xzhaous I just pushed a bunch of commits that fix more issues, and address most, if not all, of the feedback so far. To make reviewing a...