Ed Hennis

Results 183 comments of Ed Hennis

> For the amendments, do you mean for the new or the old one? And what debug level? Both? The messages I'm thinking about are written before the default level...

Just to clarify, a `Global Freeze` does not stop incoming payments to the issuer. https://xrpl.org/freezes.html#global-freeze

Suggestions. 1. Use a higher fee. Transaction submission rates are extremely high right now, but the queue is doing it's job of prioritizing the highest paying transactions. The more your...

> I'm not sure if "dead" amendments should be carried in code as "Obsolete" forever, on the other hand it only adds a few lines compared to the alternative of...

> Seems reasonable. Thanks! Could you submit a review approval? > You might also consider placing any UNL validator found voting for an obsoleted amendment on the nUNL for each...

> Just to be clear, if an "Obsolete" amendment were to (somehow) become confirmed by consensus, the server still has the code to process transactions according to that amendment so...

I've changed this PR to be a draft, indicating that it's not ready for prime time. I would like to integrate it with Conan to build the dependencies, but use...

https://github.com/XRPLF/rippled/pull/4822 contains a fix that we're planning to release in 2.0.1 (within a month of 2.0.0). If anyone is able to build that branch and run it on some of...

I notice the debug builds are still failing.

Suggested commit message: ``` Remove default ctors from SecretKey and PublicKey: (#4607) * It is now an invariant that all constructed Public Keys are valid, non-empty and contain 33 bytes...