Ed Hennis
Ed Hennis
> So accepting this change into the code base means future resources _must_ be committed to completing the refactor. If that commitment can't be made, then this branch should not...
> @ximinez @scottschurr What's your opinion? Perhaps, after taking a step back and considering all the effort required (including reviews), we've learned that this refactor is not worthwhile at this...
> That said, I think there's a problem with the most recent rebase. Toward the bottom of Feature.cpp I'm finding a use of `DefaultVote::yes` and of `DefaultVote:no` that I think...
Ok, I fixed the bad values left over from the rebase. I also marked the conversations that @scottschurr reacted to with a :+1: as resolved.
> @alloynetworks @RichardAH @WietseWind I apologize if you felt that we were ignoring you. We were not at all. Yeah, I totally thumbs upped your comments! :grinning:
Hey, did you notice that all of the unity builds had a single test failure? https://github.com/XRPLF/rippled/actions/runs/4948980242/jobs/8852057301?pr=4294
Will do as soon as I can.
CI builds should not fail. It looks like the `install-dependencies.sh` script needs to be brought over. ``` $ ( cd extras/rippled && bin/ci/ubuntu/install-dependencies.sh ../.. ) /home/travis/.travis/job_stages: line 57: cd: extras/rippled:...
@scottschurr https://github.com/ripple/validator-keys-tool also uses the lib.
It is. Make sure that the rippled download has version 1.9.1, which has this same fix. Basically, this condition gets checked twice - once by validator-keys-tool, once by rippled. If...