Ed Hennis
Ed Hennis
> is this still worth including? Should I merge it? @intelliot I think it is, yes.
It looks like you're using system-provided boost, which doesn't always have the right configuration. Try building it yourself, using the instructions on https://xrpl.org/build-run-rippled-ubuntu.html. Look for the step labelled, "Compile Boost."....
I see you proposed a commit message (https://github.com/XRPLF/rippled/pull/4751#issuecomment-2007734702), and I just added the "Passed" label. One of us will merge it soon.
Is this a fresh build? Delete your build directory and try again. If that doesn't work, delete (rename) your `~/.conan/data` directory, rebuild the conan deps, and try again.
In which branch are you seeing this happening? What are your hardware specs?
> Will those other invariants be in separate PRs, or will they be added to this same PR #4663? Separate. > My personal preference would be to break them out...
Had an accidental force push there, but cleaned it up to push 51aa79c updating some comments.
Internal tracker: https://ripplelabs.atlassian.net/browse/RPFC-111
Perf testing has passed while I was out. I've merged in `develop`, including the physical redesign. The only issue is the spurious MacOS test failure, but I think we're allowed...
@scottschurr @ckeshava The discussion in https://github.com/XRPLF/rippled/pull/4846#discussion_r1454285073 finally prompted me to clean up this branch enough to create a PR.