Ed Hennis
Ed Hennis
It's not quite the same, but there are Windows instructions in the repo: https://github.com/ripple/rippled/tree/develop/Builds/VisualStudio2017
I think one part of the problem is in `STVar`, specifically there is one ctor that takes a `depth` field, and checks ``` if (depth > 10) Throw("Maximum nesting depth...
Whatever name is chosen for the field, it needs to be ~camel~ snake case, since it's synthetic. * `name` * `object_type`
> Not `CamelCase`, `snake_case` 🙂 🤦
This PR essentially reverts commit 40cd57355db2f5367184a814367b3634505ab838, which I recently added due to comment: https://github.com/XRPLF/rippled/pull/5270#discussion_r2560543251
> Thanks for putting this proposal together, @ximinez. YW! > That said, we can work around this in the future (e.g., for Lending 2.0) by assigning a distinct pseudo-account for...
> Solution 2, item 1 - "This will give us the desired rounding automatically.". Aren't we going to loose precision by moving `SFAssetsTotal` from `STNumber` to `STAmount`? No and yes....
> If I had to pick between Solution 1 and Solution 2, I’d still lean towards 2: it feels safer and faster to ship, while 1 is more of a...
> Since we have to address precision difference for LoanBroker anyway, does it make a big difference if we address it by removing assetsAvailable in the Vault? No. > Another...
@gregtatcam @Tapanito @vlntb Thanks so much for your feedback!!! The way I'm going to proceed for right now is to go with *Solution 2*, but *completely skip steps 1 and...