Ed Hennis

With Boost 1.77, it's a different set of errors. https://gist.github.com/ximinez/ab7783cee57da1b9aa2b2507adcc3925 It looks like `unique()` just needs to be replaced with `use_count() == 1`, and I think `result_of_t` can be replaced...

The `unique()` error is fixed, but `result_of_t` is still broken. It looks like that was removed entirely from the C++-20 spec. https://en.cppreference.com/w/cpp/types/result_of

Quick note that it builds now. Tests are running. Edit: Tests passed, too.

> if I'm recalling correctly , the explicit `this` captures that you removed to make VS17 happy were added to prevent warnings from clang in C++20 mode. Should we consider...

To clarify, the clang failures I'm seeing are on your unmodified branch. I've tried both boost 1.75 and 1.77.

> Then just for completeness, I tried building on gcc (11.2.0) and clang (14.0.0). gcc worked without a hitch. clang complained about > > ``` > /home/eah/dev/rippled/merge/src/ripple/nodestore/backend/RocksDBFactory.cpp:313:44: error: arithmetic between...

Requesting a review from @seelabs, who I can't assign, because he came up with the original patch.

> I've never tried building Hooks on Windows. I will try now and see if I can shed some light on this. Edit: Windows builds are a maze. I'm going...

~Tokens / issued currencies are case sensitive. This is working as intended. https://xrpl.org/currency-formats.html#issued-currency-amounts~ Update: https://github.com/XRPLF/rippled/issues/4112#issuecomment-1057094445

Reopening this ticket. I misunderstood the issue. To clarify, there are tokens issued with mixed-case three-letter IDs. There are offers on the books for these tokens. The apparent bug is...