rippled icon indicating copy to clipboard operation
rippled copied to clipboard

Remove zaphod.alloy.ee from bootstrap

Open alloynetworks opened this issue 1 year ago • 2 comments

This PR has been made to remove the zaphod.alloy.ee hubs from the bootstrap after 5 years. It has been an honor to run these servers, but it is now time for another entity to step into this role.

The zaphod servers will be taken offline in a phased manner keeping all those who have peering arrangements informed. It is expected that this PR will be merged into the next release of rippled .

These would be the preferred attributes of a boostrap set of hubs:

  1. Commitment to run the hubs for a minimum of 2 years
  2. Highly available
  3. Geographically dispersed
  4. Secure and up to date
  5. Committed to ensure that peering information is kept private

alloynetworks avatar Jan 27 '24 13:01 alloynetworks

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.95%. Comparing base (64e4687) to head (b938f8f).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4903      +/-   ##
===========================================
- Coverage    76.95%   76.95%   -0.01%     
===========================================
  Files         1127     1127              
  Lines       131771   131769       -2     
  Branches     39608    39542      -66     
===========================================
- Hits        101408   101404       -4     
+ Misses       24460    24402      -58     
- Partials      5903     5963      +60     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 27 '24 14:01 codecov-commenter

As 2.1.0 is just around the corner, this PR should be merged into the release after that - 2.2.0.

alloynetworks avatar Feb 18 '24 08:02 alloynetworks

The example config file should also be revised accordingly.

I'm grateful for the service this hub pool has provided over the last several years.

jscottbranson avatar Feb 21 '24 17:02 jscottbranson

Good catch @jscottbranson! I'm adding this "request changes" review, so your comment doesn't get lost.

To reiterate, zaphod.alloy.ee needs to be removed from cfg/rippled-example.cfg and cfg/rippled-reporting.cfg.

The lines have been removed from the example config files.

alloynetworks avatar Feb 22 '24 05:02 alloynetworks

@alloynetworks If this is ready to merge, please add the Passed label if you have permission, or leave a comment here indicating such.

ximinez avatar Feb 22 '24 20:02 ximinez

Suggested commit message:

Remove zaphod.alloy.ee hub from default server list: (#4903)

Remove the zaphod.alloy.ee hubs from the bootstrap and default configuration after 5 years. It has been an honor to run these servers, but it is now time for another entity to step into this role.

The zaphod servers will be taken offline in a phased manner keeping all those who have peering arrangements informed.

These would be the preferred attributes of a boostrap set of hubs:

    1. Commitment to run the hubs for a minimum of 2 years
    2. Highly available
    3. Geographically dispersed
    4. Secure and up to date
    5. Committed to ensure that peering information is kept private

ximinez avatar Feb 29 '24 03:02 ximinez

some documentation I think also needs updating https://xrpl.org/docs/infrastructure/configuration/server-modes/run-rippled-as-a-validator

shortthefomo avatar Mar 05 '24 17:03 shortthefomo