rippled
rippled copied to clipboard
Remove zaphod.alloy.ee from bootstrap
This PR has been made to remove the zaphod.alloy.ee hubs from the bootstrap after 5 years. It has been an honor to run these servers, but it is now time for another entity to step into this role.
The zaphod servers will be taken offline in a phased manner keeping all those who have peering arrangements informed. It is expected that this PR will be merged into the next release of rippled
.
These would be the preferred attributes of a boostrap set of hubs:
- Commitment to run the hubs for a minimum of 2 years
- Highly available
- Geographically dispersed
- Secure and up to date
- Committed to ensure that peering information is kept private
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 76.95%. Comparing base (
64e4687
) to head (b938f8f
).
Additional details and impacted files
@@ Coverage Diff @@
## develop #4903 +/- ##
===========================================
- Coverage 76.95% 76.95% -0.01%
===========================================
Files 1127 1127
Lines 131771 131769 -2
Branches 39608 39542 -66
===========================================
- Hits 101408 101404 -4
+ Misses 24460 24402 -58
- Partials 5903 5963 +60
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As 2.1.0 is just around the corner, this PR should be merged into the release after that - 2.2.0.
The example config file should also be revised accordingly.
I'm grateful for the service this hub pool has provided over the last several years.
Good catch @jscottbranson! I'm adding this "request changes" review, so your comment doesn't get lost.
To reiterate,
zaphod.alloy.ee
needs to be removed fromcfg/rippled-example.cfg
andcfg/rippled-reporting.cfg
.
The lines have been removed from the example config files.
@alloynetworks If this is ready to merge, please add the Passed
label if you have permission, or leave a comment here indicating such.
Suggested commit message:
Remove zaphod.alloy.ee hub from default server list: (#4903)
Remove the zaphod.alloy.ee hubs from the bootstrap and default configuration after 5 years. It has been an honor to run these servers, but it is now time for another entity to step into this role.
The zaphod servers will be taken offline in a phased manner keeping all those who have peering arrangements informed.
These would be the preferred attributes of a boostrap set of hubs:
1. Commitment to run the hubs for a minimum of 2 years
2. Highly available
3. Geographically dispersed
4. Secure and up to date
5. Committed to ensure that peering information is kept private
some documentation I think also needs updating https://xrpl.org/docs/infrastructure/configuration/server-modes/run-rippled-as-a-validator