ripple-libpp
ripple-libpp copied to clipboard
ripple
Move rippled dependencies into ripple-libpp
Codecov Report
Merging #16 into master will decrease coverage by
16.83%. The diff coverage is72.82%.
@@ Coverage Diff @@
## master #16 +/- ##
===========================================
- Coverage 100% 83.16% -16.84%
===========================================
Files 1 76 +75
Lines 143 3997 +3854
===========================================
+ Hits 143 3324 +3181
- Misses 0 673 +673
| Impacted Files | Coverage Δ | |
|---|---|---|
| .../extras/beast/unit_test/detail/const_container.hpp | 100% <100%> (ø) |
|
| src/beast/extras/beast/unit_test/suite_list.hpp | 100% <100%> (ø) |
|
| src/beast/extras/beast/unit_test/global_suites.hpp | 100% <100%> (ø) |
|
| src/beast/extras/beast/unit_test/amount.hpp | 100% <100%> (ø) |
|
| src/beast/extras/beast/unit_test/match.hpp | 44.44% <44.44%> (ø) |
|
| src/beast/extras/beast/unit_test/runner.hpp | 64.61% <64.61%> (ø) |
|
| src/beast/extras/beast/unit_test/suite.hpp | 66.94% <66.94%> (ø) |
|
| src/beast/extras/beast/unit_test/suite_info.hpp | 80.64% <80.64%> (ø) |
|
| src/beast/extras/beast/unit_test/reporter.hpp | 83.33% <83.33%> (ø) |
|
| ... and 74 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update aaa1e36...15b3c28. Read the comment docs.
@ximinez @scottschurr I think this is ready for full review. Mind taking a look?
CI builds should not fail. It looks like the install-dependencies.sh script needs to be brought over.
$ ( cd extras/rippled && bin/ci/ubuntu/install-dependencies.sh ../.. )
/home/travis/.travis/job_stages: line 57: cd: extras/rippled: No such file or directory
There are a lot of changes here, clearly more than I could realistically review to any depth. Do you have some guidance for where I should spend my review time? What was the basic process you followed to make these changes? Thanks.
@scottschurr basically avoid any of the dependencies in the src/ folder. Here are some of the main files:
- https://github.com/xasos/ripple-libpp/blob/RIPD-1469/src/unity/CMakeLists.txt
- https://github.com/xasos/ripple-libpp/blob/RIPD-1469/src/unity/ripple-libpp.cpp
- https://github.com/xasos/ripple-libpp/blob/RIPD-1469/src/test/CMakeLists.txt
- https://github.com/xasos/ripple-libpp/blob/RIPD-1469/src/test/ripple-libpp_unittest.cpp And the tests set up in:
- https://github.com/xasos/ripple-libpp/tree/RIPD-1469/src/test/unity
@scottschurr https://github.com/ripple/validator-keys-tool also uses the lib.