jack

Results 48 comments of jack

Keyboard updates must target the develop branch.

Also, correct me if I'm wrong, but the only difference this keyboard has with `wilba_tech/wt65_h1` is the layout? If so, you should simply add the layout to that keyboard's `info.json`,...

It appears these could probably all be consolidated into one. I'll have a look at it now and incorporate your layout here and reach out if you're able to test.

Can you please try my [`refactor/wt65`](https://github.com/waffle87/qmk_firmware/tree/refactor/wt65/keyboards/wilba_tech/wt65_h) branch. You can check it out locally using: ```shell git remote add waffle https://github.com/waffle87/qmk_firmware git fetch waffle git checkout refactor/wt65 qmk git-submodule qmk clean...

They'll be correct to a degree... it's not magic. You still need to make the necessary changes according to your hardware. As for proceeding, you should apply the suggested changes.

There are suggestions that have not been addressed.

lesshonor's comments/suggestions are still pending.

I have marked a comment as unresolved that was not addressed.

> > If this keyboard is intended to have OLEDs installed, you need to add some OLED code in a `ghost54.c` file. There is currently none. > > Will it...

> The lint seems to be failing on a file that I didn't modify. Please advise? No need to worry about it.