jack
jack
> what else I should update? Please scroll up and see the unresolved comments.
At least two review approvals are needed before merge.
Also, see merge conflicts to be resolved.
> does that mean I need to wait until May for it to be merged into the master branch from develop Yes. The merge conflicts are product of switching the...
Ah I see, thank you for clarifying.
There are also compilation issues with the `dev` firmware. They can be viewed in the "QMK CI Build" link below.
VS Code is a good text editor, but you'll also need to get a QMK build environment setup. Follow the [newbs guide](https://docs.qmk.fm/#/newbs_getting_started) and I suggest joining the QMK discord server...
Yes. #24322 [the-via/qmk_userspace](https://github.com/the-via/qmk_userspace_via)
There are still outstanding suggestions. Please do not mark things as resolved without acknowledging them. This has been an issue on your previous PR's as well.
> Please provide a link to where this keyboard can be purchased under the Hardware Availability section.