Upload files for a new keyboard called reto60

[TactioEarth]

Upload of the files for a new keyboard called reto60

Upload of the config.h info.json readme.mb and rules.mk files together with the folder keymaps with the default keymap.c file inside.

Description

This is the first upload of all these files, testing will be done soon. Together with the VIA files once they got uploaded to qmk.

Types of Changes

• [ ] Core
• [ ] Bugfix
• [ ] New feature
• [ ] Enhancement/optimization
• [x ] Keyboard (addition or update)
• [x ] Keymap/layout/userspace (addition or update)
• [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

• [x ] My code follows the code style of this project: C, Python
• [x ] I have read the PR Checklist document and have made the appropriate changes.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ x] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[TactioEarth]

hi,

I used the qmk new-keyboard to generate the files, I thought they would be correct. How should I proceed then? I noticed the json file quite weird, but thought it was because of the generator.

Thank you!

El mié, 28 dic 2022 a las 18:33, jack @.***>) escribió:

@.**** requested changes on this pull request.

In keyboards/reto60/config.h https://github.com/qmk/qmk_firmware/pull/19439#discussion_r1058495851:

@@ -0,0 +1,20 @@

+// Copyright 2022 Á.García @.***)

This file should be removed.

In keyboards/reto60/info.json https://github.com/qmk/qmk_firmware/pull/19439#discussion_r1058496044:

•    "cols": ["C2", "C2", "C2", "C2", "C2", "C2", "C2", "C2", "C2", "C2", "C2", "C2", "C2", "C2"],
  

•    "rows": ["D1", "D1", "D1", "D1", "D1"]
  

This certainly doesn't look correct...

In keyboards/reto60/keymaps/default/keymap.c https://github.com/qmk/qmk_firmware/pull/19439#discussion_r1058496690:

@@ -0,0 +1,24 @@

+#include QMK_KEYBOARD_H

This file is missing a license header. eg.

// Copyright 2021 Your Name @.***)

// SPDX-License-Identifier: GPL-2.0-or-later

---

In keyboards/reto60/readme.md https://github.com/qmk/qmk_firmware/pull/19439#discussion_r1058496892:

+

+A short description of the keyboard/project

+* Keyboard Maintainer: Á.García

+* Hardware Supported: The PCBs, controllers supported

+* Hardware Availability: Links to where you can find this hardware

These fields should be filled out or removed.

— Reply to this email directly, view it on GitHub https://github.com/qmk/qmk_firmware/pull/19439#pullrequestreview-1231824531, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY2AK7WA4YLKVQLVPOEESHLWPR2VZANCNFSM6AAAAAATLNWFTI . You are receiving this because you authored the thread.Message ID: @.***>

-- Álvaro García

[waffle87]

They'll be correct to a degree... it's not magic. You still need to make the necessary changes according to your hardware. As for proceeding, you should apply the suggested changes.

[TactioEarth]

thanks i'll take a look , sorry for disturbing. First time desiging this stuff.

El mié, 28 dic 2022 a las 18:45, jack @.***>) escribió:

They'll be correct to a degree... it's not magic. You still need to make the necessary changes according to your hardware. As for proceeding, you should apply the suggested changes.

— Reply to this email directly, view it on GitHub https://github.com/qmk/qmk_firmware/pull/19439#issuecomment-1366818915, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY2AK7TMCB56IEOHHRDTJWTWPR4CJANCNFSM6AAAAAATLNWFTI . You are receiving this because you authored the thread.Message ID: @.***>

-- Álvaro García

[TactioEarth]

Hi, as all the checks have passed, does it merge automatically? or how should I proceed?

[zvecr]

testing will be done soon

Has this actually been tested on hardware yet? As previously the PR contained content that was not even close to being a working keyboard.

[TactioEarth]

Hi, I modified the .json file and merged it throught the DesktopApp, I swapped computers recently, but i don't see it appearing here, I don't know what happens. The software is being tested right now on it's hardware. tyvm.

[github-actions[bot]]

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[github-actions[bot]]

Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]