jack
jack
The issue with the OLED code living at the keymap level (and only in the `stock` keymap, at that) is that when a user goes to create a new keymap...
Looks like there's also a Rev 4.1 that [has some changes](https://github.com/foostan/kbd_firmware/blob/main/keyboards/crkbd/qmk/qmk_firmware/rev4_1/config.h#L3-L5) that wouldn't work with regular Rev 4.0 PCBs and vice versa. ```c #define SERIAL_USART_TX_PIN GP12 #define USB_VBUS_PIN GP13 #define...
> does this code support the extra keys for keyboards not using the rotary encoders ? @luc-vocab The layout macro(s) do (`LAYOUT_split_3xx_3_ex2`), but the keys are not mapped to anything...
> Does this pull request need t obe updated to cover v4.1 ? Yes, the code in this PR is **not** compatible with v4.1 PCBs, only v4.0. See my comment...
Generally, two collaborator reviews are required for a merge.
Keyboard updates must target develop.
> @waffle87 I thank you for the suggestions but I don't understand removing _MISC? I need to it work with my design with the OLED and with VIA. I also...
Please do not mark suggestions as resolved without addressing them. Eg. the suggestions regarding using the core tri layer feature...
> I'd like to leave the bootmagic bootloader shortcut in place, if that's acceptable, because it provides a useful fallback for entering the bootloader for users who haven't defined a...
No, all images found within QMK are hosted elsewhere (except for the single image in the repository which is the docs' favicon). Hosting anywhere on Github is discouraged as links/paths...