qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

New Keyboard Addition

Open MatchstickWorks opened this issue 1 year ago • 3 comments

Description

Adding a new board to MatchstickWorks keyboards, NormiePad

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

MatchstickWorks avatar Feb 29 '24 05:02 MatchstickWorks

The lint seems to be failing on a file that I didn't modify. Please advise?

MatchstickWorks avatar Feb 29 '24 17:02 MatchstickWorks

The lint seems to be failing on a file that I didn't modify. Please advise?

No need to worry about it.

waffle87 avatar Feb 29 '24 18:02 waffle87

Hey @drashna Could I get a re-review on this? I think the PR is still thinking a requested chance isn't resolved, but I believe we fixed it further down the discussion line.

MatchstickWorks avatar May 18 '24 05:05 MatchstickWorks

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Jul 03 '24 01:07 github-actions[bot]

I am still waiting for a review from @drashna

It's unclear to me what still needs to be addressed with this PR.

MatchstickWorks avatar Jul 03 '24 02:07 MatchstickWorks