qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Addition of Proteus67 keyboard

Open gzowski opened this issue 2 years ago • 5 comments

Description

Proteus67 keyboard, requesting it to be added to QMK as a known keyboard. Added default and VIA keymaps

Types of Changes

  • [x] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [x] Documentation

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

gzowski avatar Nov 10 '23 11:11 gzowski

could you provide further info as to whats missing from pr checklist. uncertainty as to whether it should be develop or master. removed encoder settings from keyboard rules.mk and config.h, moved settings to keymap config and rules.

gzowski avatar Nov 10 '23 14:11 gzowski

Changes made, changed pin out to use GP pin-out and elite-pi development board. formatted json. Added matrix to info.json, removed files: proteus67.c proteus67.h and proteus67.json.

gzowski avatar Nov 10 '23 16:11 gzowski

lesshonor's comments/suggestions are still pending.

waffle87 avatar Nov 11 '23 00:11 waffle87

fixed various licenses dotted around, cleared non-relevant.

gzowski avatar Nov 11 '23 21:11 gzowski

Are there any further pending changes required from my end?

gzowski avatar Nov 14 '23 11:11 gzowski