qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Added my keyboard - Ghost54

Open Ghost-Spot opened this issue 1 year ago • 3 comments

Description

I've added the keyboard 'Ghost54' to the keyboards. It's a ortho split 4x6_4 with 3 thumb keys and encoder, with OLED 64x32. I've added 2 keymaps, a 'default' and a 'via'.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Ghost-Spot avatar Feb 12 '24 00:02 Ghost-Spot

Consider placing your files within "controllerworks/" folder to reduce the number of top level keyboards folder.

filterpaper avatar Feb 12 '24 00:02 filterpaper

If this keyboard is intended to have OLEDs installed, you need to add some OLED code in a ghost54.c file. There is currently none.

Will it fail to compile if no oled info is provided?

Ghost-Spot avatar Feb 12 '24 22:02 Ghost-Spot

If this keyboard is intended to have OLEDs installed, you need to add some OLED code in a ghost54.c file. There is currently none.

Will it fail to compile if no oled info is provided?

It certainly won't be accepted for the OLED feature to enabled but not configured.

waffle87 avatar Feb 12 '24 22:02 waffle87

Closing as the bot would have marked it as stale by now, and requested changes have not been made.

zvecr avatar Jun 22 '24 03:06 zvecr