jack
jack
> Will that actually work? If I open up a PR for the keyboard code and it's dependent on the code that's in this PR, I'm pretty sure that will...
The only difference provided by this firmware to the [existing cantor firmware](https://github.com/qmk/qmk_firmware/tree/master/keyboards/cantor) is the fact it configures a slightly different processor. Is there a reason once can't just change the...
You address 2/7 of my comments. Please make the suggested changes/acknowledge you see the comments before re-requesting review.
> sir please help me by telling me what changes i need to make via enable in my keymap I practically told you what needs to be added. There is...
> Done sir the changes has been made as per via I see no new changes at the time of replying to this. Also, please do not mark comments as...
There are a couple lingering suggestions that have not been addressed.
I agree that might be more future proof, and `qmk_lufa_bootloader` could potentially be migrated under `bootloader` as well. Will see what I can do, along with migrating existing keyboards and...
Please review the PR checklist. I have unticked the box you checked asking if you have read it.