Chao Qu
Chao Qu
Yeah, I was also wondering why add_hparam creates a subdir for every call. It's not like I will change any hyper-parameters (like batch size) during each run. Would like to...
TinySolver may be missing a few noalias() calls. ``` 194 jtj_ = jacobian_.transpose() * jacobian_; 195 g_ = jacobian_.transpose() * error_; 241 dx_ = jacobi_scaling_.asDiagonal() * lm_step_; ``` I would...
If I remember correctly, matrix multiplication in Eigen assumes alias by default, so adding noalias() to those lines could avoid evaluating into a temporary matrix. For example https://github.com/ceres-solver/ceres-solver/blob/2a2b9bd6fa2a0ee62f58dceb786cb2dc3eb37630/internal/ceres/schur_eliminator.h#L505 For vector...
Here is my proposed change https://github.com/versatran01/nano_solver The change is in the Initialize() function. I made the solver non-template since I want better compilation time in my own project, which is...
This requires a thorough review of the ukf code, potentially some refactors.
I suggest fixing the issue with inconsistent map storage order first. I don't remember if this was fixed or not but worth looking at to make sure.
This is related to #146.
Can you also post links to the new packages?
This is too big for a proper review. Since it's just moving stuff around, if it builds and works we can go ahead and merge it. One thing I want...
This is just a personal preference but the namespace kr_planning_rviz_plugins has 24 characters and is a bit too long. Maybe we could just use our organizational namespace kr. For example...