Tom Rees-Herdman

Results 523 comments of Tom Rees-Herdman

Fix issues where the VRT test fails in CI before the tests have all completed

Thanks @benbowler, yes it's a bit of a shame to see this pop up again as it did seem to have improved for a bit. Thanks for taking a look!

Update Consent Mode once the Ads Conversion ID setting has been migrated to the Ads module.

Thanks @nfmohit, great spot. That one totally slipped by me. @zutigrm, please can you file a followup PR to update the condition that Nahid's highlighted? It should be returning false...

Update Consent Mode once the Ads Conversion ID setting has been migrated to the Ads module.

Apologies, I hadn't spotted @zutigrm is off today. @nfmohit has kindly offered to raise a PR to address this.

Update Consent Mode once the Ads Conversion ID setting has been migrated to the Ads module.

Top stuff, thanks @nfmohit. The PR is now merged, back to you @mohitwp to continue the QA for this one.

Only render the Audience Segmentation Setup CTA when Analytics is connected

Moved to Backlog until we get all the P1 issues done and/or the initial release out.

Only render the Audience Segmentation Setup CTA when Analytics is connected

Good shout, thanks @ankitrox!

Revise Audience Segmentation component names/locations for consistency

IB :white_check_mark:

Revise Audience Segmentation component names/locations for consistency

Moved to Backlog until we get all the P1 issues done and/or the initial release out.

Prevent Selection Panel Info Notice from disappearing until two audiences are selected

Thanks @nfmohit - I should have been more explicit in the AC. The not should indeed not reappear - I've updated the AC accordingly.

Syncing audiences and custom dimensions in parallel can result in the cached audiences not being persisted

Moved to Backlog until we get all the P1 issues done and/or the initial release out.