Tom Rees-Herdman

Results 525 comments of Tom Rees-Herdman

Use the `useInViewSelect()` hook where applicable in the Audience Segmentation feature

Thanks Nahid, no worries!

Fix glitches when closing various modal dialogs

Hi @juniovitorino, thanks for drafting this IB. It's off to a good start, but a few points need addressing: - The fact that we don't know how to resolve the...

Fix glitches when closing various modal dialogs

Noting here that this issue has been split in order to address the focus issues separately via https://github.com/google/site-kit-wp/issues/10548.

Fix glitches when closing various modal dialogs

Thanks @juniovitorino - did you see my comment on [Slack](https://fueled10up.slack.com/archives/C077DB69US2/p1743091876818969?thread_ts=1743083617.027599&cid=C077DB69US2), though? I think you are pretty close to wrapping this one up. Maybe we can pair on this one as...

Fix glitches when closing various modal dialogs

Thanks for flagging that, @benbowler. As this is @juniovitorino's first IB, I feel it would be valuable for him to complete it. However your addition is useful, so let's use...

Fix glitches when closing various modal dialogs

@juniovitorino, thanks for updating the IB. A few points: - Having split the issue in two, there are now only five dialogs in the AC; please remove the extra two...

Fix glitches when closing various modal dialogs

Thanks @juniovitorino, good to know. Please can you also address this point from my previous review? > Having split the issue in two, there are now only five dialogs in...

Fix glitches when closing various modal dialogs

Thanks for the update @juniovitorino, the IB LGTM. IB ✅

Add GA event tracking for the Audience Selection Panel

> > **ITEM 3:** For the view_notification event, it triggers when user views the success notification in the Audience Creation Notice. > > Let's say there are 2 audiences to...

Add GA event tracking for the Audience Selection Panel

Back to you for another pass, @kelvinballoo!