Tom Rees-Herdman

Results 188 comments of Tom Rees-Herdman

## QA:Eng :white_check_mark: As stated [above](https://github.com/google/site-kit-wp/issues/4776#issuecomment-1251148512) by @aaemnnosttv the `QA:Eng` scenario is confirmed done with the tests now passing on his older PHP environment where they were previously failing. >...

Sounds like a plan @kuasha420, I've added ACs, assigning to @aaemnnosttv to take a look.

Thanks @aaemnnosttv, that is a good point and I have added a bit of detail about that to the AC. Please let me know if you want any further detail...

Nice work @nfmohit. Maybe it could be written a bit less verbosely, but it reads very well as it stands. It can be hard to know where to draw the...

> @felixarntz I spent some time looking into this today related to another issue and was able to get it working in a way that seems normal in the browser...

Hi @jimmymadon, this IB is looking good. A couple of details: - `isModuleConnected` should be used, rather than `isModuleActive`, for Analytics this ensures the check is made for the property...

> @techanvil I did some testing on this recently and it may be related to caching. See the notes within the QA brief in another issue (#1646) Thanks @jamesozzie, that's...

Hi @aaemnnosttv, thanks for clarifying that. It's good to know this is expected behaviour on a technical level. It still feels a bit confusing to me from a user perspective,...

@aaemnnosttv yup I can see it being problematic to get the behavioural parity between the button vs browser navigation... Probably solvable but only by modding the service and adding extra...