Tom Rees-Herdman
Tom Rees-Herdman
Hey @hussain-t, happy to report I've just merged the PR for this and moved the issue to QA. Just dropping you a heads up that I made a small tweak...
Back to you @kelvinballoo! :)
Hi @kelvinballoo and @wpdarren, thanks for raising this. The general design philosophy of Site Kit is to reuse generic components to achieve a consistent look and feel. So, reusing the...
I've moved this back to Backlog as the final [in-progress changes to the design doc](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit?disco=AAABJiKQwSo), relating to audience caching, will probably affect the AC for this one
The audience caching aspect of the design doc has been sufficiently finalised, and I've moved this back to AC.
Hey @hussain-t, if the available audiences are synced after the user creates one of the audiences, the notice for the other should still remain while the panel is still open...
Thanks @hussain-t. I'm unassigning this for now as I hadn't actually picked this up for review, although I'm happy to do so if nobody else gets it first!
Thanks @hussain-t. I have ended up picking this one up for IBR :) Before I get into the detail, a high level consideration I have when reviewing this is that,...
Thanks @hussain-t. I think splitting the issue is the way to go here. I realise the IB is already defined - but, it's worth remembering that the guidance is for...
Thanks @hussain-t! This, and the IBs for the other issues are LGTM. IB :white_check_mark: