site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

Only render the Audience Segmentation Setup CTA when Analytics is connected

Open techanvil opened this issue 1 year ago • 2 comments

Feature Description

This is a small cleanup, as at present the Setup CTA won't actually be displayed when Analytics isn't connected due to its internal check for Analytics data availability on load. However it would be preferable to entirely avoid rendering the component when Analytics is not connected, thus avoiding redundant Analytics store lookups and so forth.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The Audience Segmentation Setup CTA should only be rendered when the Analytics module is connected.

Implementation Brief

  • [ ] Include a check for Analytics being connected in the conditions for rendering AudienceSegmentationSetupCTAWidget in DashboardMainApp.

https://github.com/google/site-kit-wp/blob/774ea23c2471170c96898f11c1909dedf6bc5db3/assets/js/components/DashboardMainApp.js#L262-L264

Test Coverage

  • No new tests needed.

QA Brief

Changelog entry

techanvil avatar Jun 14 '24 15:06 techanvil

IB ✅

nfmohit avatar Jun 23 '24 10:06 nfmohit

Moved to Backlog until we get all the P1 issues done and/or the initial release out.

techanvil avatar Jun 27 '24 11:06 techanvil

@techanvil This issue can be closed as this has not handled by new Banner component as can be seen here.

ankitrox avatar Jul 11 '25 10:07 ankitrox

Good shout, thanks @ankitrox!

techanvil avatar Jul 16 '25 10:07 techanvil