site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

Revise Audience Segmentation component names/locations for consistency

Open techanvil opened this issue 1 year ago • 2 comments

Feature Description

Some of the components for the Audience Segmentation feature are named or located a bit inconsistently. As can be seen, some are prefixed AudienceSegmentation - there is a certain logic to it but nonetheless it does look a bit inconsistent, and it's arguably redundant to an extent as they are located within the audience-segmentation folder.

Also, the term VisitorGroups is used for the settings components, this is contrary to the rest which use "audience" terminology.

One more detail is that InfoNotice is only used within the InfoNoticeWidget component and so it should be moved to the InfoNoticeWidget folder.

image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The Audience Segmentation component names and locations should be revised and updated for consistency.

Implementation Brief

  • [ ] Remove the AudienceSegmentation* prefix for the files; assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSegmentation*.
  • [ ] Move the assets/js/modules/analytics-4/components/audience-segmentation/dashboard/InfoNotice* files into the assets/js/modules/analytics-4/components/audience-segmentation/dashboard/InfoNoticeWidget/ component folder.
  • [ ] Replace VisitorGroups with Audience in the files assets/js/modules/analytics-4/components/audience-segmentation/settings/SettingsCardVisitorGroups*.

Test Coverage

  • No additional test coverage required.

QA Brief

Changelog entry

techanvil avatar Jun 14 '24 16:06 techanvil

IB :white_check_mark:

techanvil avatar Jun 24 '24 10:06 techanvil

Moved to Backlog until we get all the P1 issues done and/or the initial release out.

techanvil avatar Jun 27 '24 11:06 techanvil