Tom Rees-Herdman comments

Results 523 comments of


                                            Tom Rees-Herdman

Tag Manager permission error not shown to user

Thanks @benbowler! The IB pretty much LGTM, although I'm not sure we need to lower-case the message so I've tweaked it to remove that detail. IB :white_check_mark:

Scroll to the Audiences Widget Area from the Setup Success Notice

Thanks @benbowler, yes, the intention is to dismiss the notification as well (i.e. maintain the current behaviour). I've updated the AC to make it clearer. IB :white_check_mark:

Add the Full Width Error Banner (Storybook)

Thanks @hussain-t! Back to you for another pass, @kelvinballoo.

Add the Full Width Error Banner (Storybook)

Thanks @hussain-t, that's merged :+1: Back to you @kelvinballoo!

Update the "insufficient permissions" modals to display the second sentence on a separate line.

Update: This may no longer be required, as the Figma designs have been updated. To be reviewed when revisiting this issue.

Implement the unhappy paths for the Setup CTA Banner

Hi @hussain-t, just letting you know I've moved this back to Backlog as the final [in-progress changes to the design doc](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit?disco=AAABJiKQwSo), relating to audience caching, will probably affect the AC...