Tom Rees-Herdman
Tom Rees-Herdman
@eugene-manuilov, in practical terms I think it would just mean passing an array of errors into `WidgetReportError` as `ReportErrorActions` [looks up the selector name and args](https://github.com/google/site-kit-wp/blob/ab9d76bebe8a3368eaf73b194edf941fd42f2ec5/assets/js/components/ReportErrorActions.js#L65-L75) from the error object(s)......
Thanks @benbowler, the IB LGTM :white_check_mark:
@eugene-manuilov @hussain-t actually, per-user settings are fine here. For one thing this setting was not intended to follow the primary admin's. More importantly to be aware of though, is we're...
@eugene-manuilov, I think the default value should be `false` - it's similar to the `isWidgetHidden` Key Metrics setting which is a user setting: https://github.com/google/site-kit-wp/blob/c173f6c206ce0b7f2eb0777b0acfe3bfe649c385/includes/Core/Key_Metrics/Key_Metrics_Settings.php#L48-L53 This KM setting already works in...
Update: Due to ongoing changes to the design doc, we may well want to expand the scope of this issue to include the additional `configuredAudiences` setting. Let's hold off until...
Update: With Evan having approved the changes, and Mariya already having given her general approval for the direction (so really just needing to sign off on the details), it's clear...
@hussain-t, as discussed on Slack the AC does need a small tweak: > We can't use `getConfiguredAudiences()` to return the value for `isAudienceSegmentationWidgetHidden()` because `getConfiguredAudiences()` only returns `configuredAudiences` and not...
Thanks @hussain-t, the AC LGTM :white_check_mark: Assigning to you in IB as requested. Remember, we don't literally have to directly fetch the value from `GET audience-settings` in each selector, we...
> Good catch @aaemnnosttv! It looks like we missed it 😮 Would you like us to address this via a follow-up PR, or create a new issue? Hmm, actually this...
Thanks @aaemnnosttv. Your suggestion to make the in-view state dependent on the open/closed state is a good one. Actually, it got me wondering if we could take a simpler approach...