Sören Zapp

With the recently added function `G1CP_NpcIsInRoutine`, the issue can be fixed like so https://github.com/AmProsius/gothic-1-community-patch/blob/66e2fc2c1b10525ec27416debc509e5ceb409ff0/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_KDF_401_Damarok.d#L62-L69 changed to ```D FUNC int KDF_401_Damarok_HEAL_Condition() { if (Npc_GetTrueGuild (hero) == GIL_KDF) && (G1CP_NpcIsInRoutine(self, Rtn_START_401)) {...

I added another step: > 10. _Optionally_ turn the issue into a pull request: `hub pull-request -i XXX`.

I wonder if this should be a local script, that a collaborator triggers on their own machine, or a Github bot that commits the automated changes and turns the issue...

It would be awesome to somehow encode the necessary info in the issue. > Variables to know: > > * Issue number (`XXX`) > * Issue name (_optional_) > *...

The if-conditions are arranged incorrectly. The `else if` which is checking for the death of the NPCs can never be reached, if the variable `Stooges_Fled` is not true, i.e. if...

This language dependent issue is present in both English and German scripts. Relevant script portion: EN https://github.com/AmProsius/gothic-1-community-patch/blob/b946ba1189a6937510bfbfaeff64a2df55d9cccb/scriptbase/_work/Data/Scripts/Content/Items/MissionItems_1.d#L1225-L1239 DE https://github.com/AmProsius/gothic-1-community-patch/blob/ba24fbc87c1603d1699e67e94e6c812772b6fa88/scriptbase/_work/Data/Scripts/Content/Items/MissionItems_1.d#L1225-L1239 For implementation, see #149. Note: The same problem appears for the...

It would be nice to know the exact context when that happens, i.e. a reliable way to reproduce the issue. Without that, it will be impossible to test if the...

Thanks. I updated your comment to include the original script. Unfortunately, that solution seems incomplete. The variable `Ricelord_AskedForWater_Day` does not exist. I guess it will be added to the dialog...

> The variable` Lefty_WorkDay` update in Dialogs on Lefty Yes, but it will never be higher than `Wld_GetDay()` (expect just before midnight): https://github.com/AmProsius/gothic-1-community-patch/blob/c5097df6da1f67bcaff41f81dff3396f804de583/scriptbase/_work/Data/Scripts/Content/Story/B/B_SetDayTolerance.d#L1-L11 Therefore the change in comparison makes no...

I think the only thing addressing the issue is the condition ``` (Ricelord_AskedForWater_Day != (Wld_GetDay() + 1)) ``` We should add something like that.