Markus Staab
Markus Staab
you are right.. param types should only be done on new major versions. dropped the param type changes
I guess this will be fixed as soon as we release a new version with min-php version 8.1
@iceman-fx magst du einen PR dafür erstellen?
I think the remaining error is a bug: https://github.com/phpstan/phpstan/issues/11249
sorry for all these commits to make it finally build on php 7.2 without errors.
related upstream issues - https://github.com/phpstan/phpstan/issues/12927 - https://github.com/phpstan/phpstan/issues/12926 - https://github.com/phpstan/phpstan/issues/12928
as is, this consitutues a BC break (as can be seen in all the errors of the CI pipeline). problem is, that extension can exist which just check for `!$context->null()`,...
> What's the BC break? after this PR extensions like `CountFunctionTypeSpecifyingExtension` are now getting called `specifyTypes` method for the `comparison` context and they now specify the type in said cases....
what do you think about `TypeSpecifierComparisonContext `? should I drop that class and turn all the properties this object currently holds into parameters to the new method `ComparisonAwareTypeSpecifyingExtension ` will...
the POC works now equally to the pre-existing impl. IMO pluggin the `TypeSpecifierComparisonContext` into the `TypeSpecifierContext` makes the PR more complicated than it needs to be. since we need the...